From c334175319949f6887dcab89afb32f1bb38e9f88 Mon Sep 17 00:00:00 2001 From: Sirio Balmelli Date: Tue, 3 Sep 2024 11:25:58 +0200 Subject: nixos/github-runner: quote comma separators so as to pass shellcheck Shellcheck complains: > args=( > ^-- SC2054 (warning): Use spaces, not commas, to separate array elements. Quote the --labels argument to resolve. Signed-off-by: Sirio Balmelli --- modules/services/github-runner/service.nix | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) (limited to 'modules/services/github-runner/service.nix') diff --git a/modules/services/github-runner/service.nix b/modules/services/github-runner/service.nix index 75d6442..175b22d 100644 --- a/modules/services/github-runner/service.nix +++ b/modules/services/github-runner/service.nix @@ -90,7 +90,7 @@ in let configure = pkgs.writeShellApplication { name = "configure-github-runner-${name}"; - text = '' + text = /*bash*/'' export RUNNER_ROOT args=( @@ -98,7 +98,7 @@ in --disableupdate --work ${escapeShellArg workDir} --url ${escapeShellArg cfg.url} - --labels ${escapeShellArg (concatStringsSep "," cfg.extraLabels)} + --labels "${escapeShellArg (concatStringsSep "," cfg.extraLabels)}" ${optionalString (cfg.name != null ) "--name ${escapeShellArg cfg.name}"} ${optionalString cfg.replace "--replace"} ${optionalString (cfg.runnerGroup != null) "--runnergroup ${escapeShellArg cfg.runnerGroup}"} -- cgit v1.2.3