From def1e23be848848400d1d097d4f044e3c401f9dd Mon Sep 17 00:00:00 2001 From: Weijia Wang <9713184+wegank@users.noreply.github.com> Date: Sun, 14 Apr 2024 23:02:32 +0200 Subject: treewide: remove lib.mdDoc --- modules/lib/write-text.nix | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) (limited to 'modules/lib/write-text.nix') diff --git a/modules/lib/write-text.nix b/modules/lib/write-text.nix index b8f2ad5..2fe02af 100644 --- a/modules/lib/write-text.nix +++ b/modules/lib/write-text.nix @@ -16,7 +16,7 @@ in enable = mkOption { type = types.bool; default = true; - description = lib.mdDoc '' + description = '' Whether this file should be generated. This option allows specific files to be disabled. ''; @@ -25,7 +25,7 @@ in text = mkOption { type = types.lines; default = ""; - description = lib.mdDoc '' + description = '' Text of the file. ''; }; @@ -33,14 +33,14 @@ in target = mkOption { type = types.str; default = name; - description = lib.mdDoc '' + description = '' Name of symlink. Defaults to the attribute name. ''; }; source = mkOption { type = types.path; - description = lib.mdDoc '' + description = '' Path of the source file. ''; }; @@ -48,7 +48,7 @@ in copy = mkOption { type = types.bool; default = false; - description = lib.mdDoc '' + description = '' Whether this file should be copied instead of symlinking. ''; }; -- cgit v1.2.3 From 36a15e8c6c4686be29ccbf0ae0ac1d6133074615 Mon Sep 17 00:00:00 2001 From: Emily Date: Sun, 16 Jul 2023 17:02:10 +0100 Subject: write-text: remove support for `copy` MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit This is a huge anti‐declarative footgun; `copy` files cannot distinguish if a previous version is managed by nix-darwin, so they can’t check the hash, so they’re prone to destroying data, and copied files are not deleted when they’re removed from the system configuration, which led to a security bug. Nothing else in‐tree was using this functionality, so let’s make sure it doesn’t cause any more bugs. --- modules/lib/write-text.nix | 8 -------- 1 file changed, 8 deletions(-) (limited to 'modules/lib/write-text.nix') diff --git a/modules/lib/write-text.nix b/modules/lib/write-text.nix index 2fe02af..ddf4076 100644 --- a/modules/lib/write-text.nix +++ b/modules/lib/write-text.nix @@ -45,14 +45,6 @@ in ''; }; - copy = mkOption { - type = types.bool; - default = false; - description = '' - Whether this file should be copied instead of symlinking. - ''; - }; - knownSha256Hashes = mkOption { internal = true; type = types.listOf types.str; -- cgit v1.2.3