summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorПавел Жуков <33721692+LeaveMyYard@users.noreply.github.com>2023-05-16 12:32:41 +0300
committeravi robusta <avi@robusta.dev>2023-05-16 13:22:35 +0300
commitcc3ebdd5c5745a3a3738201c5f5e5595d2da8277 (patch)
treedaa307e0f665c1ea32e70dbcdba3e0f30dc357e0
parent4e8d9817cd153a29b0c78e02c5abaa9712707a1c (diff)
Add info logs
-rw-r--r--robusta_krr/core/integrations/kubernetes.py11
-rw-r--r--robusta_krr/core/integrations/prometheus/loader.py4
-rw-r--r--robusta_krr/core/runner.py2
-rw-r--r--robusta_krr/main.py2
4 files changed, 12 insertions, 7 deletions
diff --git a/robusta_krr/core/integrations/kubernetes.py b/robusta_krr/core/integrations/kubernetes.py
index 030016d..5081361 100644
--- a/robusta_krr/core/integrations/kubernetes.py
+++ b/robusta_krr/core/integrations/kubernetes.py
@@ -38,7 +38,7 @@ class ClusterLoader(Configurable):
A list of scannable objects.
"""
- self.debug(f"Listing scannable objects in {self.cluster}")
+ self.info(f"Listing scannable objects in {self.cluster}")
self.debug(f"Namespaces: {self.config.namespaces}")
try:
@@ -56,9 +56,14 @@ class ClusterLoader(Configurable):
objects = itertools.chain(*objects_tuple)
if self.config.namespaces == "*":
# NOTE: We are not scanning kube-system namespace by default
- return [obj for obj in objects if obj.namespace != "kube-system"]
+ result = [obj for obj in itertools.chain(*objects_tuple) if obj.namespace != "kube-system"]
else:
- return [obj for obj in objects if obj.namespace in self.config.namespaces]
+ result = [obj for obj in itertools.chain(*objects_tuple) if obj.namespace in self.config.namespaces]
+
+ namespaces = {obj.namespace for obj in result}
+ self.info(f"Found {len(result)} objects across {len(namespaces)} namespaces in {self.cluster}")
+
+ return result
@staticmethod
def _get_match_expression_filter(expression) -> str:
diff --git a/robusta_krr/core/integrations/prometheus/loader.py b/robusta_krr/core/integrations/prometheus/loader.py
index 9db140e..685dd1c 100644
--- a/robusta_krr/core/integrations/prometheus/loader.py
+++ b/robusta_krr/core/integrations/prometheus/loader.py
@@ -66,7 +66,7 @@ class PrometheusLoader(Configurable):
) -> None:
super().__init__(config=config)
- self.debug(f"Initializing PrometheusLoader for {cluster or 'default'} cluster")
+ self.info(f"Connecting to Prometheus for {cluster or 'default'} cluster")
self.auth_header = self.config.prometheus_auth_header
self.ssl_enabled = self.config.prometheus_ssl_enabled
@@ -93,7 +93,7 @@ class PrometheusLoader(Configurable):
self.prometheus = CustomPrometheusConnect(url=self.url, disable_ssl=not self.ssl_enabled, headers=headers)
self._check_prometheus_connection()
- self.debug(f"PrometheusLoader initialized for {cluster or 'default'} cluster")
+ self.info(f"Prometheus connected successfully for {cluster or 'default'} cluster")
def _check_prometheus_connection(self):
try:
diff --git a/robusta_krr/core/runner.py b/robusta_krr/core/runner.py
index 7ba1d72..bff6acb 100644
--- a/robusta_krr/core/runner.py
+++ b/robusta_krr/core/runner.py
@@ -129,7 +129,7 @@ class Runner(Configurable):
async def _collect_result(self) -> Result:
clusters = await self._k8s_loader.list_clusters()
- self.debug(f'Using clusters: {clusters if clusters is not None else "inner cluster"}')
+ self.info(f'Using clusters: {clusters if clusters is not None else "inner cluster"}')
objects = await self._k8s_loader.list_scannable_objects(clusters)
if len(objects) == 0:
diff --git a/robusta_krr/main.py b/robusta_krr/main.py
index 33671e4..fdd654d 100644
--- a/robusta_krr/main.py
+++ b/robusta_krr/main.py
@@ -77,7 +77,7 @@ def load_commands() -> None:
rich_help_panel="Prometheus Settings",
),
format: str = typer.Option("table", "--formatter", "-f", help="Output formatter ({formatters})", rich_help_panel="Logging Settings"),
- verbose: bool = typer.Option(True, "--verbose", "-v", help="Enable verbose mode", rich_help_panel="Logging Settings"),
+ verbose: bool = typer.Option(False, "--verbose", "-v", help="Enable verbose mode", rich_help_panel="Logging Settings"),
quiet: bool = typer.Option(False, "--quiet", "-q", help="Enable quiet mode", rich_help_panel="Logging Settings"),
log_to_stderr: bool = typer.Option(False, "--logtostderr", help="Pass logs to stderr", rich_help_panel="Logging Settings"),
{strategy_settings},