From 5e4e23289bb8bf8632d5f898b05e12a4cb899f27 Mon Sep 17 00:00:00 2001 From: Maxime Coste Date: Tue, 21 Nov 2023 17:16:38 +1100 Subject: Fix completion menu not getting hidden on no matches --- src/input_handler.cc | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) (limited to 'src/input_handler.cc') diff --git a/src/input_handler.cc b/src/input_handler.cc index 9bc495a2..61d6faa4 100644 --- a/src/input_handler.cc +++ b/src/input_handler.cc @@ -1132,6 +1132,9 @@ private: line.byte_count_to(m_line_editor.cursor_pos())); if (not context().has_client()) return; + if (m_completions.candidates.empty()) + return context().client().menu_hide(); + show_completions(); const bool menu = (bool)(m_completions.flags & Completions::Flags::Menu); if (menu) @@ -1148,9 +1151,6 @@ private: void show_completions() { - if (m_completions.candidates.empty()) - return context().client().menu_hide(); - Vector items; for (auto& candidate : m_completions.candidates) items.push_back({ candidate, {} }); @@ -1183,7 +1183,7 @@ private: display(); if (from_pop) { - if (context().has_client()) + if (context().has_client() and not m_completions.candidates.empty()) { show_completions(); const bool menu = (bool)(m_completions.flags & Completions::Flags::Menu); -- cgit v1.2.3