From e51ef6c3c29ca23c342776a19bdb9bcfc257875d Mon Sep 17 00:00:00 2001 From: Maxime Coste Date: Thu, 22 Oct 2015 13:48:57 +0100 Subject: Wrap the shell params en env vars in a ShellContext struct --- src/command_manager.hh | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) (limited to 'src/command_manager.hh') diff --git a/src/command_manager.hh b/src/command_manager.hh index 9592bce6..d47dbdbc 100644 --- a/src/command_manager.hh +++ b/src/command_manager.hh @@ -61,8 +61,7 @@ class CommandManager : public Singleton { public: void execute(StringView command_line, Context& context, - ConstArrayView shell_params = {}, - const EnvVarMap& env_vars = EnvVarMap{}); + const ShellContext& shell_context = {}); Completions complete(const Context& context, CompletionFlags flags, StringView command_line, ByteCount cursor_pos); @@ -104,8 +103,7 @@ private: }; String expand(StringView str, const Context& context, - ConstArrayView shell_params = {}, - const EnvVarMap& env_vars = EnvVarMap{}); + const ShellContext& shell_context = {}); } -- cgit v1.2.3 From da7fc3311fba98bde4fbc3457fdbf2503fd2b4d0 Mon Sep 17 00:00:00 2001 From: Maxime Coste Date: Thu, 22 Oct 2015 13:59:23 +0100 Subject: Pass ShellContext to commands Fix #427 --- src/command_manager.hh | 10 ++++++++-- 1 file changed, 8 insertions(+), 2 deletions(-) (limited to 'src/command_manager.hh') diff --git a/src/command_manager.hh b/src/command_manager.hh index d47dbdbc..f2d49761 100644 --- a/src/command_manager.hh +++ b/src/command_manager.hh @@ -19,11 +19,15 @@ namespace Kakoune class Context; using CommandParameters = ConstArrayView; -using Command = std::function; +using Command = std::function; + using CommandCompleter = std::function; + using CommandHelper = std::function; enum class CommandFlags @@ -84,7 +88,9 @@ public: private: void execute_single_command(CommandParameters params, - Context& context, CharCoord pos) const; + Context& context, + const ShellContext& shell_context, + CharCoord pos) const; struct CommandDescriptor { -- cgit v1.2.3 From 1ba37bacd8cda9c24d074887e2c10a8881f9c861 Mon Sep 17 00:00:00 2001 From: Maxime Coste Date: Fri, 23 Oct 2015 09:49:06 +0100 Subject: Fix optimized linkage --- src/command_manager.hh | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) (limited to 'src/command_manager.hh') diff --git a/src/command_manager.hh b/src/command_manager.hh index f2d49761..2251e8b7 100644 --- a/src/command_manager.hh +++ b/src/command_manager.hh @@ -65,7 +65,7 @@ class CommandManager : public Singleton { public: void execute(StringView command_line, Context& context, - const ShellContext& shell_context = {}); + const ShellContext& shell_context = ShellContext{}); Completions complete(const Context& context, CompletionFlags flags, StringView command_line, ByteCount cursor_pos); @@ -109,7 +109,7 @@ private: }; String expand(StringView str, const Context& context, - const ShellContext& shell_context = {}); + const ShellContext& shell_context = ShellContext{}); } -- cgit v1.2.3