From dfc11d1c43b898394df8fda52a8079b34058de27 Mon Sep 17 00:00:00 2001
From: Maxime Coste <mawww@kakoune.org>
Date: Tue, 23 Oct 2018 08:15:53 +1100
Subject: Refactor Hook management to have a well defined list of hooks

Hooks are now an enum class instead of passing strings around.
---
 src/buffer.cc | 14 +++++++-------
 1 file changed, 7 insertions(+), 7 deletions(-)

(limited to 'src/buffer.cc')

diff --git a/src/buffer.cc b/src/buffer.cc
index 8ef76a09..5d3702eb 100644
--- a/src/buffer.cc
+++ b/src/buffer.cc
@@ -114,16 +114,16 @@ void Buffer::on_registered()
         return;
     }
 
-    run_hook_in_own_context("BufCreate", m_name);
+    run_hook_in_own_context(Hook::BufCreate, m_name);
 
     if (m_flags & Flags::File)
     {
         if (m_flags & Buffer::Flags::New)
-            run_hook_in_own_context("BufNewFile", m_name);
+            run_hook_in_own_context(Hook::BufNewFile, m_name);
         else
         {
             kak_assert(m_fs_timestamp != InvalidTime);
-            run_hook_in_own_context("BufOpenFile", m_name);
+            run_hook_in_own_context(Hook::BufOpenFile, m_name);
         }
     }
 
@@ -139,7 +139,7 @@ void Buffer::on_unregistered()
         return;
 
     options().unregister_watcher(*this);
-    run_hook_in_own_context("BufClose", m_name);
+    run_hook_in_own_context(Hook::BufClose, m_name);
 }
 
 Buffer::~Buffer()
@@ -687,11 +687,11 @@ void Buffer::on_option_changed(const Option& option)
         else
             m_flags &= ~Flags::ReadOnly;
     }
-    run_hook_in_own_context("BufSetOption",
+    run_hook_in_own_context(Hook::BufSetOption,
                             format("{}={}", option.name(), option.get_as_string(Quoting::Kakoune)));
 }
 
-void Buffer::run_hook_in_own_context(StringView hook_name, StringView param, String client_name)
+void Buffer::run_hook_in_own_context(Hook hook, StringView param, String client_name)
 {
     if (m_flags & Buffer::Flags::NoHooks)
         return;
@@ -699,7 +699,7 @@ void Buffer::run_hook_in_own_context(StringView hook_name, StringView param, Str
     InputHandler hook_handler{{ *this, Selection{} },
                               Context::Flags::Draft,
                               std::move(client_name)};
-    hooks().run_hook(hook_name, param, hook_handler.context());
+    hooks().run_hook(hook, param, hook_handler.context());
 }
 
 Optional<BufferCoord> Buffer::last_modification_coord() const
-- 
cgit v1.2.3