From 370d10ccc7b19fee5d10332a7c6b934376ed2df7 Mon Sep 17 00:00:00 2001 From: Maxime Coste Date: Wed, 23 Jan 2019 19:48:43 +1100 Subject: Always select inserted text after piping Relying on general selection update code is error prone due to diffing. Fixes #2394 --- src/buffer.cc | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) (limited to 'src/buffer.cc') diff --git a/src/buffer.cc b/src/buffer.cc index 5d3702eb..40b07eb6 100644 --- a/src/buffer.cc +++ b/src/buffer.cc @@ -484,7 +484,7 @@ BufferCoord Buffer::do_insert(BufferCoord pos, StringView content) : BufferCoord{ last_line, m_lines[last_line].length() - suffix.length() }; m_changes.push_back({ Change::Insert, pos, end }); - return pos; + return end; } BufferCoord Buffer::do_erase(BufferCoord begin, BufferCoord end) @@ -809,7 +809,8 @@ UnitTest test_buffer{[]() UnitTest test_undo{[]() { Buffer buffer("test", Buffer::Flags::None, "allo ?\nmais que fais la police\n hein ?\n youpi\n"); - auto pos = buffer.insert(buffer.end_coord(), "kanaky\n"); // change 1 + auto pos = buffer.end_coord(); + buffer.insert(pos, "kanaky\n"); // change 1 buffer.commit_undo_group(); buffer.erase(pos, buffer.end_coord()); // change 2 buffer.commit_undo_group(); -- cgit v1.2.3