summaryrefslogtreecommitdiff
path: root/funcs
diff options
context:
space:
mode:
authorDave Henderson <dhenderson@gmail.com>2021-01-02 12:42:36 -0500
committerDave Henderson <dhenderson@gmail.com>2021-01-02 12:49:40 -0500
commit25042240754ae032f53f2225e2f224cbfe51b2b6 (patch)
tree5530b07d4928a483d1d34be3138605f6014b422a /funcs
parent09a33cdffa6d0b4e57e12827f7075fb2d6c6a543 (diff)
Moving lint config to config file, fixing some issues
Signed-off-by: Dave Henderson <dhenderson@gmail.com>
Diffstat (limited to 'funcs')
-rw-r--r--funcs/conv_test.go1
-rw-r--r--funcs/math_test.go9
-rw-r--r--funcs/strings.go6
3 files changed, 13 insertions, 3 deletions
diff --git a/funcs/conv_test.go b/funcs/conv_test.go
index 1342787e..9fbfb8bb 100644
--- a/funcs/conv_test.go
+++ b/funcs/conv_test.go
@@ -28,6 +28,7 @@ func TestDefault(t *testing.T) {
}
for _, d := range data {
+ d := d
t.Run(fmt.Sprintf("%T/%#v empty==%v", d.val, d.val, d.empty), func(t *testing.T) {
if d.empty {
assert.Equal(t, def, c.Default(def, d.val))
diff --git a/funcs/math_test.go b/funcs/math_test.go
index d47a3c09..f9e2b20e 100644
--- a/funcs/math_test.go
+++ b/funcs/math_test.go
@@ -126,6 +126,7 @@ func TestIsIntFloatNum(t *testing.T) {
}
m := MathNS()
for _, tt := range tests {
+ tt := tt
t.Run(fmt.Sprintf("%T(%#v)", tt.in, tt.in), func(t *testing.T) {
assert.Equal(t, tt.isInt, m.IsInt(tt.in))
assert.Equal(t, tt.isFloat, m.IsFloat(tt.in))
@@ -140,6 +141,7 @@ func BenchmarkIsFloat(b *testing.B) {
}
m := MathNS()
for _, n := range data {
+ n := n
b.Run(fmt.Sprintf("%T(%v)", n, n), func(b *testing.B) {
for i := 0; i < b.N; i++ {
m.IsFloat(n)
@@ -164,6 +166,7 @@ func TestMax(t *testing.T) {
{[]interface{}{"14", "0xff", -5}, int64(255)},
}
for _, d := range data {
+ d := d
t.Run(fmt.Sprintf("%v==%v", d.n, d.expected), func(t *testing.T) {
var actual interface{}
if len(d.n) == 1 {
@@ -192,6 +195,7 @@ func TestMin(t *testing.T) {
{[]interface{}{"14", "0xff", -5}, int64(-5)},
}
for _, d := range data {
+ d := d
t.Run(fmt.Sprintf("%v==%v", d.n, d.expected), func(t *testing.T) {
var actual interface{}
if len(d.n) == 1 {
@@ -223,6 +227,7 @@ func TestContainsFloat(t *testing.T) {
{[]interface{}{"NaN"}, true},
}
for _, d := range data {
+ d := d
t.Run(fmt.Sprintf("%v==%v", d.n, d.expected), func(t *testing.T) {
if d.expected {
assert.True(t, m.containsFloat(d.n...))
@@ -248,6 +253,7 @@ func TestCeil(t *testing.T) {
{-1.9, -1},
}
for _, d := range data {
+ d := d
t.Run(fmt.Sprintf("%v==%v", d.n, d.a), func(t *testing.T) {
assert.InDelta(t, d.a, m.Ceil(d.n), 1e-12)
})
@@ -269,6 +275,7 @@ func TestFloor(t *testing.T) {
{-1.9, -2.},
}
for _, d := range data {
+ d := d
t.Run(fmt.Sprintf("%v==%v", d.n, d.a), func(t *testing.T) {
assert.InDelta(t, d.a, m.Floor(d.n), 1e-12)
})
@@ -294,6 +301,7 @@ func TestRound(t *testing.T) {
{-4.5, -5},
}
for _, d := range data {
+ d := d
t.Run(fmt.Sprintf("%v==%v", d.n, d.a), func(t *testing.T) {
assert.InDelta(t, d.a, m.Round(d.n), 1e-12)
})
@@ -318,6 +326,7 @@ func TestAbs(t *testing.T) {
{-2, int64(2)},
}
for _, d := range data {
+ d := d
t.Run(fmt.Sprintf("%#v==%v", d.n, d.a), func(t *testing.T) {
assert.Equal(t, d.a, m.Abs(d.n))
})
diff --git a/funcs/strings.go b/funcs/strings.go
index ec45ab2b..7a18c96e 100644
--- a/funcs/strings.go
+++ b/funcs/strings.go
@@ -210,18 +210,18 @@ func (f *StringFuncs) Indent(args ...interface{}) (string, error) {
if !ok {
width, ok = args[0].(int)
if !ok {
- return "", errors.New("Indent: invalid arguments")
+ return "", errors.New("indent: invalid arguments")
}
indent = " "
}
case 3:
width, ok = args[0].(int)
if !ok {
- return "", errors.New("Indent: invalid arguments")
+ return "", errors.New("indent: invalid arguments")
}
indent, ok = args[1].(string)
if !ok {
- return "", errors.New("Indent: invalid arguments")
+ return "", errors.New("indent: invalid arguments")
}
}
return gompstrings.Indent(width, indent, input), nil