From df2d85634233dbf8ae154c29cf164eebba89eff5 Mon Sep 17 00:00:00 2001 From: Jeffrey Regan Date: Fri, 3 Mar 2017 15:09:16 -0800 Subject: Close #420 General theme: * Move remaining community stuff out of kubernetes/kubernetes. * Put self-contained things into their own MD files. * Point to those files rather than repeat their content. * Make all docs smaller, but more of them. See companion PR in kubernetes/kubernetes --- CONTRIBUTING.md | 36 +++++++++++++++++++++++++----------- 1 file changed, 25 insertions(+), 11 deletions(-) (limited to 'CONTRIBUTING.md') diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md index 00591970..8dc16c3e 100644 --- a/CONTRIBUTING.md +++ b/CONTRIBUTING.md @@ -1,16 +1,30 @@ -# Contributing guidelines +# Contributing to the community repo -This project is for documentation about the community. To contribute to one of -the Kubernetes projects please see the contribution guide for that project. -## How To Contribute +Contributions to this community repository follow a +[pull request](https://help.github.com/articles/using-pull-requests/) (PR) +model: -The contributions here follow a [pull request](https://help.github.com/articles/using-pull-requests/) model with some additional process. -The process is as follows: +#### 1. Submit a PR with your change -1. Submit a pull request with the requested change. -2. Another person, other than a Special Interest Group (SIG) owner, can mark it Looks Good To Me (LGTM) upon successful review. Otherwise feedback can be given. -3. A SIG owner can merge someone else's change into their SIG documentation immediate. -4. Someone cannot immediately merge their own change. To merge your own change wait 24 hours during the week or 72 hours over a weekend. This allows others the opportunity to review a change. +#### 2. Get an LGTM. -_Note, the SIG Owners decide on the layout for their own sub-directory structure._ +Upon successful review, someone will give the PR +a __LGTM__ (_looks good to me_) in the review thread. + +#### 3. Allow time for others to see it + +Once you have an __LGTM__, please wait 24 hours during +the week or 72 hours over a weekend before you +merge it, to give others (besides your initial reviewer) +time to see it. + +__That said, a [SIG lead](sig-list.md) may shortcut this by merging +someone else's change into their SIG's documentation +at any time.__ + +Edits in SIG sub-directories should follow structure and guidelines set +by the respective SIG leads - see `CONTRIBUTING` instructions in subdirectories. + + + \ No newline at end of file -- cgit v1.2.3