From fec46af679a671d8ecf30a3b5dcb62b40c6d7272 Mon Sep 17 00:00:00 2001 From: YuPengZTE Date: Mon, 26 Sep 2016 17:05:53 +0800 Subject: The VS and dot is seprated Signed-off-by: YuPengZTE --- api-conventions.md | 4 ++-- faster_reviews.md | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/api-conventions.md b/api-conventions.md index 4a9c6fc1..7fc2bdfc 100644 --- a/api-conventions.md +++ b/api-conventions.md @@ -63,7 +63,7 @@ resources](../user-guide/working-with-resources.md).* - [List Operations](#list-operations) - [Map Operations](#map-operations) - [Idempotency](#idempotency) - - [Optional vs Required](#optional-vs-required) + - [Optional vs. Required](#optional-vs-required) - [Defaulting](#defaulting) - [Late Initialization](#late-initialization) - [Concurrency Control and Consistency](#concurrency-control-and-consistency) @@ -658,7 +658,7 @@ exists - instead, it will either return 201 Created or 504 with Reason allotted, and the client should retry (optionally after the time indicated in the Retry-After header). -## Optional vs Required +## Optional vs. Required Fields must be either optional or required. diff --git a/faster_reviews.md b/faster_reviews.md index 11fcbe72..b15d9c52 100644 --- a/faster_reviews.md +++ b/faster_reviews.md @@ -109,7 +109,7 @@ fast-moving codebase - lock in your changes ASAP, and make merges be someone else's problem. Obviously, we want every PR to be useful on its own, so you'll have to use -common sense in deciding what can be a PR vs what should be a commit in a larger +common sense in deciding what can be a PR vs. what should be a commit in a larger PR. Rule of thumb - if this commit or set of commits is directly related to Feature-X and nothing else, it should probably be part of the Feature-X PR. If you can plausibly imagine someone finding value in this commit outside of -- cgit v1.2.3