From 6eece46e694e70eb455c8ceee37b0f623fed1946 Mon Sep 17 00:00:00 2001 From: Connor Doyle Date: Thu, 20 Jul 2017 17:12:14 -0700 Subject: Updated topo discovery section with decision. --- contributors/design-proposals/cpu-manager.md | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/contributors/design-proposals/cpu-manager.md b/contributors/design-proposals/cpu-manager.md index c886880c..f60364e6 100644 --- a/contributors/design-proposals/cpu-manager.md +++ b/contributors/design-proposals/cpu-manager.md @@ -88,7 +88,10 @@ hyper-threading turned on yields both sibling threads on the same physical core. Likewise, allocating two CPUs on a non-hyper-threaded system yields two cores on the same socket. -##### Options for discovering topology +**Decision:** Initially the CPU Manager will re-use the existing discovery +mechanism in cAdvisor. + +Alternate options considered for discovering topology: 1. Read and parse the virtual file [`/proc/cpuinfo`][procfs] and construct a convenient data structure. @@ -98,8 +101,6 @@ system yields two cores on the same socket. contains code to build a ThreadSet from the output of `lscpu -p`. 1. Execute a mature external topology program like [`mpi-hwloc`][hwloc] -- potentially adding support for the hwloc file format to the Kubelet. -1. Re-use existing discovery functionality from cAdvisor. **(preferred initial - solution)** #### CPU Manager interfaces (sketch) -- cgit v1.2.3