From 29c0d95ce17b18d791f6eb3e174ed1443ca4ee6c Mon Sep 17 00:00:00 2001 From: Marky Jackson Date: Wed, 1 Jun 2022 15:19:00 +0000 Subject: [Issues 6606] Add updated slack-guidelines Signed-off-by: markyjackson-taulia --- communication/slack-guidelines.md | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/communication/slack-guidelines.md b/communication/slack-guidelines.md index 869dc2c4..3045b34f 100644 --- a/communication/slack-guidelines.md +++ b/communication/slack-guidelines.md @@ -162,8 +162,10 @@ To add a channel, open a Pull Request (PR) updating the [slack-config][]. - Special accommodations will be made where necessary. After you submit your request the Slack Admins will review and follow-up with -any questions in the PR itself. Once it is signed off and merged, the channel -will be created. +any questions in the PR itself. +There are two approvals needed. `/lgtm` and `/approved`. Once one moderator give the `/lgtm`, a hold will be placed on the PR using `/hold`. This hold will remain in place until one or more moderators reviews +and add the `/approve` label as well as `/hold cancel`, which will remove the hold on the PR. +Once it is signed off and merged, the channel will be created. For further information, see the [Slack Config Documentation][]. -- cgit v1.2.3 From 1630383af8a7d9f212f730a3706667a23ab5ed7c Mon Sep 17 00:00:00 2001 From: Marky Jackson Date: Fri, 10 Jun 2022 11:37:38 -0700 Subject: Update communication/slack-guidelines.md Co-authored-by: Christoph Blecker --- communication/slack-guidelines.md | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/communication/slack-guidelines.md b/communication/slack-guidelines.md index 3045b34f..a9f6afa4 100644 --- a/communication/slack-guidelines.md +++ b/communication/slack-guidelines.md @@ -163,8 +163,8 @@ To add a channel, open a Pull Request (PR) updating the [slack-config][]. After you submit your request the Slack Admins will review and follow-up with any questions in the PR itself. -There are two approvals needed. `/lgtm` and `/approved`. Once one moderator give the `/lgtm`, a hold will be placed on the PR using `/hold`. This hold will remain in place until one or more moderators reviews -and add the `/approve` label as well as `/hold cancel`, which will remove the hold on the PR. +There are two approvals needed. `/lgtm` and `/approve`. Once one moderator give the `/lgtm`, a hold will be placed on the PR using `/hold`. This hold will remain in place until one or more moderators reviews +and add the `/approve` command as well as `/hold cancel`, which will remove the hold on the PR. Once it is signed off and merged, the channel will be created. For further information, see the [Slack Config Documentation][]. -- cgit v1.2.3