From 3cf30ed472ca666295ba06dcd0840b317d61ee31 Mon Sep 17 00:00:00 2001 From: Ryan Phillips Date: Mon, 28 Aug 2017 11:06:43 -0500 Subject: include Xiang's comments --- contributors/design-proposals/apiserver-count-fix.md | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/contributors/design-proposals/apiserver-count-fix.md b/contributors/design-proposals/apiserver-count-fix.md index a9150914..0b17772f 100644 --- a/contributors/design-proposals/apiserver-count-fix.md +++ b/contributors/design-proposals/apiserver-count-fix.md @@ -57,8 +57,12 @@ Endpoints would never become consistent. The MasterCountEndpointReconciler does not meet the current needs for durability of API Endpoint creation, deletion, or failure cases. -Custom Resource Definitions and ConfigMaps were proposed, but since they are -watched globally, liveliness updates could be overly chatty. +Custom Resource Definitions were proposed, but they do not have clean layering. +Additionally, liveness and locking would be a nice to have feature for a long +term solution. + +ConfigMaps were proposed, but since they are watched globally, liveliness +updates could be overly chatty. By porting OpenShift's [LeaseEndpointReconciler](https://github.com/openshift/origin/blob/master/pkg/cmd/server/election/lease_endpoint_reconciler.go) -- cgit v1.2.3