From 2e0ee29a3a4fa0a645933d73fc55611a2e9bcb6f Mon Sep 17 00:00:00 2001 From: Nikhita Raghunath Date: Thu, 21 Jun 2018 16:21:47 +0530 Subject: godep: add instruction to commit after godep save --- contributors/devel/godep.md | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/contributors/devel/godep.md b/contributors/devel/godep.md index 4f81c85e..128ee326 100644 --- a/contributors/devel/godep.md +++ b/contributors/devel/godep.md @@ -145,6 +145,8 @@ calculate which deps are needed, and rebuild the database. It will also regenerate other metadata files which the project needs, such as BUILD files and the LICENSE database. +Commit the changes before updating deps in staging repos. + ## Saving deps in staging repos Kubernetes stores some code in a directory called `staging` which is handled @@ -156,6 +158,8 @@ transitively), you'll also need to update deps there: ./hack/update-staging-godeps.sh ``` +Then commit the changes generated by the above script. + ## Commit messages Terse messages like "Update foo.org/bar to 0.42" are problematic -- cgit v1.2.3